eli-schwartz commented on PR #2249:
URL: https://github.com/apache/orc/pull/2249#issuecomment-2954181672
Meson doesn't have strong opinions about what version you use.
If you build ORC as a third-party vendored dependency of some other project,
and that project ALSO uses protobuf, then that other project, being the
top-level project, gets "first dibs" on building a copy of protobuf. There can
only be one version per build directory, due to the diamond dependency rule.
The diamond dependency rule can't really be "solved" by build systems. If
you try to link multiple versions of protobuf into one executable process
space, they will stomp on each others' internal data.
If ORC requires specific versions of protobuf and fails otherwise, that
information should be encoded as:
```meson
dependency('protobuf', version: ['>=minimum', '<=maximum'])
```
which will of course be respected.
If it supports multiple versions but there's a specific recommended one, use
whichever version makes both you and the reviewers happy :D probably the one
currently in use.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
