eli-schwartz commented on code in PR #2249:
URL: https://github.com/apache/orc/pull/2249#discussion_r2135864457
##########
c++/meson.build:
##########
@@ -16,7 +16,8 @@
# under the License.
# required dependencies
-protobuf_dep = dependency('protobuf')
+protobuf_proj = subproject('protobuf')
+protobuf_dep = protobuf_proj.get_variable('protobuf_dep')
Review Comment:
No. :(
Without updating the wrap itself, the best way to workaround this is
probably to check protobuf_dep.type_name() == 'internal' to figure out if a
subproject was used. If so, `subproject('protobuf').get_variable('protoc')` is
"safe" to use as it will use the existing configured fallback subproject.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]