eli-schwartz commented on code in PR #2249:
URL: https://github.com/apache/orc/pull/2249#discussion_r2135821867
##########
c++/meson.build:
##########
@@ -16,7 +16,8 @@
# under the License.
# required dependencies
-protobuf_dep = dependency('protobuf')
+protobuf_proj = subproject('protobuf')
+protobuf_dep = protobuf_proj.get_variable('protobuf_dep')
Review Comment:
Why are you switching to explicit subproject() here? This doesn't hook into
the dependency cache, so meson has no visibility into the fact that it's the
same thing as `dependency('protobuf')` and it cannot warn you that you're about
to pull in multiple incompatible versions of a diamond dependency.
It looks like you're just doing this because the wrap file is an older style
and doesn't include a `[provide]` section. The correct way to solve this is not
via `subproject()`, but via the *older style* of `dependency()`, which is,
adding the `fallback: ['protobuf', 'protobuf_dep']` kwarg to the existing
`dependency()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
