linyiqun commented on a change in pull request #1613:
URL: https://github.com/apache/ozone/pull/1613#discussion_r532012845
##########
File path: hadoop-ozone/interface-client/src/main/proto/OmClientProtocol.proto
##########
@@ -74,6 +74,7 @@ enum Type {
DBUpdates = 53;
FinalizeUpgrade = 54;
FinalizeUpgradeProgress = 55;
+ Prepare = 56;
Review comment:
Can we rename to PrepareUpgrade which can be more readable? In the
design doc, it also called PrepareUpgrade request.
##########
File path: hadoop-ozone/interface-client/src/main/proto/OmClientProtocol.proto
##########
@@ -145,6 +146,7 @@ message OMRequest {
optional DBUpdatesRequest dbUpdatesRequest =
53;
optional FinalizeUpgradeRequest finalizeUpgradeRequest =
54;
optional FinalizeUpgradeProgressRequest finalizeUpgradeProgressRequest =
55;
+ optional PrepareRequest prepareRequest =
56;
Review comment:
Can we rename to PrepareUpgradeRequest/PrepareUpgradeResponse?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
