errose28 commented on a change in pull request #1613:
URL: https://github.com/apache/ozone/pull/1613#discussion_r532690606
##########
File path: hadoop-ozone/interface-client/src/main/proto/OmClientProtocol.proto
##########
@@ -145,6 +146,7 @@ message OMRequest {
optional DBUpdatesRequest dbUpdatesRequest =
53;
optional FinalizeUpgradeRequest finalizeUpgradeRequest =
54;
optional FinalizeUpgradeProgressRequest finalizeUpgradeProgressRequest =
55;
+ optional PrepareRequest prepareRequest =
56;
Review comment:
The design doc and flow diagram are a bit inconsistent with usage of
PrepareRequest or PrepareUpgradeRequest. We were initially planning on calling
it PrepareUpgradeRequest during the design phase, but later decided that the
command is not actually specific to upgrades. It will also be used for
downgrades, and it is really a more general operation to clear out the OM logs,
without any upgrade/downgrade specific actions in it. We opted to keep the name
generic to reflect this.
@avijayanhwx let me know if I missed anything here, and your current
thoughts on the prepare vs. prepareUpgrade naming.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
