swamirishi commented on code in PR #8203:
URL: https://github.com/apache/ozone/pull/8203#discussion_r2047907041
##########
hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/utils/db/RDBStoreCodecBufferIterator.java:
##########
@@ -84,38 +92,77 @@ CodecBuffer getFromDb() {
}
}
- private final Buffer keyBuffer;
- private final Buffer valueBuffer;
+ private final Stack<RawKeyValue<Buffer>> availableBufferStack;
Review Comment:
I initially used a queue but I realized we may not have to allocate all
buffers all the time. LIFO is better than FIFO in such cases. My buffer
allocation would be minimal with a stack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
