swamirishi commented on code in PR #8203:
URL: https://github.com/apache/ozone/pull/8203#discussion_r2047944009
##########
hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/utils/db/RDBStoreCodecBufferIterator.java:
##########
@@ -84,38 +92,77 @@ CodecBuffer getFromDb() {
}
}
- private final Buffer keyBuffer;
- private final Buffer valueBuffer;
+ private final Stack<RawKeyValue<Buffer>> availableBufferStack;
Review Comment:
Instead of having a custom blocking stack implementation I have changed it
to using BlockingDeque instead which provides these functionalities. As part of
this change I had to handle race conditions with the inuseBufferSet values.
Since we need to handle 2 data structures in consistently.
Please take a look at this and check which is lesser complex we can go ahead
with whatever approach we all align with.
##########
hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/utils/db/RDBStoreCodecBufferIterator.java:
##########
@@ -84,38 +92,77 @@ CodecBuffer getFromDb() {
}
}
- private final Buffer keyBuffer;
- private final Buffer valueBuffer;
+ private final Stack<RawKeyValue<Buffer>> availableBufferStack;
Review Comment:
Instead of having a custom blocking stack implementation I have changed it
to using BlockingDeque instead which provides these functionalities. As part of
this change I had to handle race conditions with the inuseBufferSet values.
Since we need to handle 2 data structures consistently.
Please take a look at this and check which is lesser complex we can go ahead
with whatever approach we all align with.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
