swamirishi commented on PR #8203: URL: https://github.com/apache/ozone/pull/8203#issuecomment-2813656612
> > ThreadLocal will not work. > > It will work. > > > Moreover ThreadLocal will end up creating too many buffers which IMO is very wasteful. > > No, it won't. > > @swamirishi , Since this is a new iterator implementation, let's create a new class for it. It is quite invasive and risky to change the existing code. We should make it configurable. If we find some bugs later on, we could set the conf to use the old iterator. @szetszwo I will go ahead and make this as a separate implementation. But the downstream usages of these classes would be really messy with if else conditions the idea of which I don't like. I would be still ok if we eventually want to get rid of the old implementation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
