SaketaChalamchala commented on code in PR #8214:
URL: https://github.com/apache/ozone/pull/8214#discussion_r2056701760


##########
hadoop-hdds/rocksdb-checkpoint-differ/src/main/java/org/apache/ozone/compaction/log/CompactionFileInfo.java:
##########
@@ -32,16 +32,26 @@ public final class CompactionFileInfo {
   private final String startKey;
   private final String endKey;
   private final String columnFamily;
+  private boolean pruned;

Review Comment:
   Shouldn't two CompactionFileInfo objects be the equal if filename, 
columnFamily, start and end key are the same regardless of whether the file is 
pruned?
   The same goes for hashCode, shouldn't the CompactionFileInfo for the same 
file generate the same hash regardless of whether it is pruned.  



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to