hemantk-12 commented on code in PR #8214:
URL: https://github.com/apache/ozone/pull/8214#discussion_r2056795222
##########
hadoop-hdds/rocksdb-checkpoint-differ/src/main/java/org/apache/ozone/rocksdiff/RocksDBCheckpointDiffer.java:
##########
@@ -237,8 +256,22 @@ public class RocksDBCheckpointDiffer implements
AutoCloseable,
this::pruneSstFiles,
pruneCompactionDagDaemonRunIntervalInMs,
pruneCompactionDagDaemonRunIntervalInMs,
- TimeUnit.MILLISECONDS
- );
+ TimeUnit.MILLISECONDS);
+
+ try {
+ isNativeLibsLoaded = ManagedRawSSTFileReader.loadLibrary();
Review Comment:
I missed adding `twice` (updated previous comment).
> native library initialization to RocksDBCheckpointDiffer and just check if
native library is loaded in SnapshotDiffManager?
Nah, I meant initialize `ManagedRawSSTFileReader` only when it is not
already initialized, like [lazy
load](https://en.wikipedia.org/wiki/Singleton_pattern#Lazy_initialization).
Not related to this patch, why do we have a T typed ManagedRawSSTFileReader?
It should be independent of type IMO.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
