SaketaChalamchala commented on code in PR #8214:
URL: https://github.com/apache/ozone/pull/8214#discussion_r2056750556
##########
hadoop-hdds/rocksdb-checkpoint-differ/src/main/java/org/apache/ozone/rocksdiff/RocksDBCheckpointDiffer.java:
##########
@@ -1140,7 +1193,17 @@ private void addFileInfoToCompactionLogTable(
builder.setCompactionReason(compactionReason);
}
- addToCompactionLogTable(builder.build());
+ CompactionLogEntry compactionLogEntry = builder.build();
+ byte[] key = addToCompactionLogTable(compactionLogEntry);
+ // Add the compaction log entry to the prune queue so that the backup
input sst files can be pruned.
+ if (isNativeLibsLoaded) {
+ try {
+ pruneQueue.put(Pair.of(key, compactionLogEntry));
+ } catch (InterruptedException e) {
+ LOG.error("Could not add backup SST files in queue to be pruned. {}",
+ compactionLogEntry.getInputFileInfoList(), e);
+ }
+ }
Review Comment:
Agree. Just out of curiosity, is there any thread other than during OM
startup and onCompactionComplete listener thread that can update the
compactionLogTable?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
