ChenSammi commented on code in PR #8845:
URL: https://github.com/apache/ozone/pull/8845#discussion_r2238133008
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/block/ScmBlockDeletingServiceMetrics.java:
##########
@@ -272,6 +315,19 @@ public void getMetrics(MetricsCollector metricsCollector,
boolean all) {
.addGauge(DatanodeCommandDetails.BLOCKS_SENT_TO_DN_COMMAND,
e.getValue().getBlocksSent());
}
+
+ // add metrics for deleted block transaction summary
+ if (blockManager.getDeletedBlockLog().isTransactionSummarySupported()) {
Review Comment:
We need a feature flag to mark a clear point that which deletion tx will be
counted into summary, and others will be ignored.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]