sreejasahithi commented on code in PR #10079:
URL: https://github.com/apache/ozone/pull/10079#discussion_r3084172297


##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/ha/SCMStateMachine.java:
##########
@@ -77,6 +78,7 @@ public class SCMStateMachine extends BaseStateMachine {
 
   private StorageContainerManager scm;
   private Map<RequestType, Object> handlers;
+  private Map<RequestType,  ScmInvoker<?>> invokers;

Review Comment:
   ```suggestion
     private Map<RequestType, ScmInvoker<?>> invokers;
   ```



##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/ha/invoker/ScmInvokerCodeGenerator.java:
##########
@@ -72,6 +72,12 @@ public final class ScmInvokerCodeGenerator {
       Object.class,
       new Class<?>[]{Exception.class});
 
+  static final DeclaredMethod GET_RETURN_TYPE = new 
DeclaredMethod("getReturnType",
+      new Class[]{String.class, Class[].class},
+      new String[]{"methodName", "parameterTypes"},
+      Class.class,
+      new Class<?>[]{});
+

Review Comment:
   This is not used anywhere.



##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/ha/invoker/ScmInvokerCodeGenerator.java:
##########


Review Comment:
   Not related to your change but ,
   here it should be tmp.getAbsolutePath() instead of java.getAbsolutePath()



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to