adoroszlai commented on code in PR #10079:
URL: https://github.com/apache/ozone/pull/10079#discussion_r3091514424


##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/ha/SCMRatisServerImpl.java:
##########
@@ -223,6 +224,9 @@ public SCMStateMachine getSCMStateMachine() {
   @Override
   public void registerStateMachineHandler(final RequestType handlerType,
                                           final Object handler) {
+    if (handler instanceof ScmInvoker) {
+      stateMachine.registerInvoker(handlerType, (ScmInvoker) handler);

Review Comment:
   I don't think this method is called with `ScmInvoker`, rather 
`invoker.getImpl()`.
   
   
https://github.com/apache/ozone/blob/874dad783b7dbe319edde54da4e519901a8f2f3a/hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/ha/SCMRatisServer.java#L75-L76
   
   ```
   [main] INFO ha.SCMRatisServerImpl: registerStateMachineHandler(FINALIZE, 
org.apache.hadoop.hdds.scm.server.upgrade.FinalizationStateManagerImpl@273a5a8a):
 invoker=false
   [main] INFO ha.SCMRatisServerImpl: registerStateMachineHandler(SEQUENCE_ID, 
org.apache.hadoop.hdds.scm.ha.SequenceIdGenerator$StateManagerImpl@76544c0a): 
invoker=false
   [main] INFO ha.SCMRatisServerImpl: registerStateMachineHandler(PIPELINE, 
org.apache.hadoop.hdds.scm.pipeline.PipelineStateManagerImpl@57a6a933): 
invoker=false
   [main] INFO ha.SCMRatisServerImpl: registerStateMachineHandler(CONTAINER, 
org.apache.hadoop.hdds.scm.container.ContainerStateManagerImpl@31f295b6): 
invoker=false
   [main] INFO ha.SCMRatisServerImpl: registerStateMachineHandler(BLOCK, 
org.apache.hadoop.hdds.scm.block.DeletedBlockLogStateManagerImpl@423a0e1d): 
invoker=false
   [main] INFO ha.SCMRatisServerImpl: 
registerStateMachineHandler(STATEFUL_SERVICE_CONFIG, 
org.apache.hadoop.hdds.scm.ha.StatefulServiceStateManagerImpl@1c240cf2): 
invoker=false
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to