szetszwo commented on code in PR #10079:
URL: https://github.com/apache/ozone/pull/10079#discussion_r3088225030


##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/ha/invoker/DeletedBlockLogStateManagerInvoker.java:
##########
@@ -115,7 +119,9 @@ public Object invokeLocal(String methodName, Object[] p) 
throws Exception {
       return null;

Review Comment:
   @Russole , For void.class, we probably should return `Message.EMPTY`.  Sorry 
that I missed it last time.
   
   > Further improvements to ScmInvokerCodeGenerator will be handled in a 
separate JIRA.
   
   I agree to change ScmInvokerCodeGenerator separately after we make sure that 
the code change is good.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to