sodonnel commented on code in PR #10084:
URL: https://github.com/apache/ozone/pull/10084#discussion_r3117087677


##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/SCMClientProtocolServer.java:
##########
@@ -1168,6 +1173,30 @@ public HddsProtos.UpgradeStatus queryUpgradeStatus() 
throws IOException {
     }
   }
 
+  static HddsProtos.UpgradeStatus buildUpgradeStatus(
+      UpgradeFinalization.Status scmUpgradeStatus,
+      int finalizedDatanodes,
+      int healthyDatanodes) {
+    return HddsProtos.UpgradeStatus.newBuilder()
+        .setScmFinalized(isScmFinalized(scmUpgradeStatus))
+        .setNumDatanodesFinalized(finalizedDatanodes)
+        .setNumDatanodesTotal(healthyDatanodes)
+        .setShouldFinalize(
+            shouldFinalize(scmUpgradeStatus, finalizedDatanodes, 
healthyDatanodes))
+        .build();
+  }
+
+  static boolean isScmFinalized(UpgradeFinalization.Status scmUpgradeStatus) {
+    return UpgradeFinalization.isFinalized(scmUpgradeStatus)
+        || UpgradeFinalization.isDone(scmUpgradeStatus);
+  }
+
+  static boolean shouldFinalize(UpgradeFinalization.Status scmUpgradeStatus,
+      int finalizedDatanodes, int healthyDatanodes) {
+    return 
UpgradeFinalization.Status.FINALIZATION_REQUIRED.equals(scmUpgradeStatus)

Review Comment:
   Yea we can tweak the CLI output, as what is there is just kind of a 
placeholder and we still need to add the JSON part. Possibly the Should 
Finalize part doesn't even need to be in the human readable part and only in 
the JSON response. We can consider it more in another PR.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to