0lai0 commented on PR #9286: URL: https://github.com/apache/ozone/pull/9286#issuecomment-4286428727
Thanks @echonesis and @adoroszlai for review. Addressed all review points and fixed the follow-up build/test issues. `BucketEndpoint.java` - Removed restored ACL handling from get() (ACL remains handled by BucketAclHandler). - Updated listMultipartUploads(...) call to pass delimiter and encodingType. - Kept simplified auditReadSuccess(s3GAction) call. - Removed redundant prefix-length check and applied startsWith(prefix) filtering consistently. - Fixed pagination accounting by incrementing processedUploads in the max-uploads/same-prefix continue path. - Fixed missing locals in handleGetRequest (maxUploads) and used context.setAction(...) for multipart uploads path. `ListMultipartUploadsHandler.java` - Aligned handler with current ListMultipartUploadsResult types (EncodingTypeObject fields and upload key type). - Added delimiter / encodingType handling and encoding-type validation. - Set Delimiter and EncodingType in response, and wrapped key marker/prefix fields correctly. These changes bring the implementation in line with HDDS-12336 and resolve the reported compile/runtime test failures. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
