0lai0 commented on code in PR #9286:
URL: https://github.com/apache/ozone/pull/9286#discussion_r3129575216
##########
hadoop-ozone/s3gateway/src/main/java/org/apache/hadoop/ozone/s3/endpoint/BucketEndpoint.java:
##########
@@ -118,6 +121,17 @@ Response handleGetRequest(S3RequestContext context, String
bucketName) throws IO
OzoneBucket bucket = null;
try {
+ if (prefix == null) {
+ prefix = "";
+ }
+ final String uploads = queryParams().get(QueryParams.UPLOADS);
+ if (uploads != null) {
Review Comment:
Thanks @adoroszlai for the feedback. Here's my attempt at a fix. Please let
me know if this approach makes sense.
I updated the patch accordingly:
- Removed multipart-upload specific methods from BucketEndpoint and kept
multipart listing handled only by ListMultipartUploadsHandler.
- Implemented actual prefix/delimiter handling in
ListMultipartUploadsHandler (including CommonPrefixes grouping and pagination
marker handling).
- Fixed TestBucketList compile issues and updated tests to use the current
endpoint/query-params flow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
