adoroszlai commented on code in PR #9286:
URL: https://github.com/apache/ozone/pull/9286#discussion_r3124313959
##########
hadoop-ozone/s3gateway/src/main/java/org/apache/hadoop/ozone/s3/endpoint/BucketEndpoint.java:
##########
@@ -118,6 +121,17 @@ Response handleGetRequest(S3RequestContext context, String
bucketName) throws IO
OzoneBucket bucket = null;
try {
+ if (prefix == null) {
+ prefix = "";
+ }
+ final String uploads = queryParams().get(QueryParams.UPLOADS);
+ if (uploads != null) {
Review Comment:
Thanks @0lai0 for the update, however:
- `TestBucketList` has compile error.
- In `ListMultipartUploadsHandler` I only see changes related to the
response, but not to handling prefix and delimiter in the actual list.
- Still there are changes in `BucketEndpoint`. Please remove these:
https://github.com/apache/ozone/blob/ff5fbae2218966b66cef00453f97e92687428736/hadoop-ozone/s3gateway/src/main/java/org/apache/hadoop/ozone/s3/endpoint/BucketEndpoint.java#L282-L290
https://github.com/apache/ozone/blob/ff5fbae2218966b66cef00453f97e92687428736/hadoop-ozone/s3gateway/src/main/java/org/apache/hadoop/ozone/s3/endpoint/BucketEndpoint.java#L347-L355
https://github.com/apache/ozone/blob/ff5fbae2218966b66cef00453f97e92687428736/hadoop-ozone/s3gateway/src/main/java/org/apache/hadoop/ozone/s3/endpoint/BucketEndpoint.java#L123-L125
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
