spacemonkd commented on code in PR #10094:
URL: https://github.com/apache/ozone/pull/10094#discussion_r3129714935
##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/.eslintrc.json:
##########
@@ -36,13 +37,7 @@
"allowTemplateLiterals": true
}
],
- "no-unused-vars": [
- "warn",
- {
- "argsIgnorePattern": "^_\\w*",
- "varsIgnorePattern": "^_\\w*"
- }
- ],
+ "no-unused-vars": "off",
Review Comment:
We should enable this, mostly because we don't want to keep un-necessary
vars.
What do you think?
The reason for the pattern matching was that in some cases (like using
map(), filter() etc the callback provides arguments in a specific order. If we
need some argument from the middle then we would need a placeholder variable to
unpack the values.
In this case we want to allow un-used variables, but in general we do not
want to encourage this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
