will-sh commented on code in PR #10094:
URL: https://github.com/apache/ozone/pull/10094#discussion_r3131407395
##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/.eslintrc.json:
##########
@@ -76,7 +71,6 @@
"react/require-default-props": "off",
"react/default-props-match-prop-types": "off",
"react/no-array-index-key": "off",
- "promise/prefer-await-to-then": "warn",
Review Comment:
I checked the current package.json and .eslintrc.json, and it seems that the
required `eslint-plugin-promise` dependency was actually never installed in
this project, and the "promise" plugin is missing from the plugins array.
To fix this properly, should we add:
1. Install the missing plugin via `pnpm add -D eslint-plugin-promise `
2. Add "promise" to the plugins array in .eslintrc.json
3. Add "promise/prefer-await-to-then": "warn" back to the rules.
And this involves adding a new dev dependency to package.json and
pnpm-lock.yaml, does this sound like the right approach?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
