will-sh commented on code in PR #10094:
URL: https://github.com/apache/ozone/pull/10094#discussion_r3131274849


##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/.eslintrc.json:
##########
@@ -76,7 +71,6 @@
       "react/require-default-props": "off",
       "react/default-props-match-prop-types": "off",
       "react/no-array-index-key": "off",
-      "promise/prefer-await-to-then": "warn",

Review Comment:
   I agree! I found there are 25 places still use .then()
   ```
   $ cd 
./hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src && 
grep -rn "\.then(" .|wc -l
   25
   ```
   shall we keep `"promise/prefer-await-to-then": "warn",` and we could raise a 
separate jira to correct these 25 places to use await?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to