ashishkumar50 commented on code in PR #10000:
URL: https://github.com/apache/ozone/pull/10000#discussion_r3172549299
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/ContainerManagerImpl.java:
##########
@@ -269,6 +269,7 @@ private ContainerInfo allocateContainer(final Pipeline
pipeline,
}
containerStateManager.addContainer(containerInfoBuilder.build());
+ pipelineManager.recordPendingAllocation(pipeline, containerID);
Review Comment:
I have made `hasEnoughSpace` and `recordPendingAllocation` atomic and will
be used during new container allocation. But still i have kept `hasEnoughSpace`
and `recordPendingAllocation` methods as we need this during replication which
is used by placement policy for space check. In placement policy there is no
container id so it can just check for space and later record by replication
manager. There is already subtask for it HDDS-14924. If there are some over
allocation of container during replication it should be accepted by datanode
soft and hard limit check which is being handled in
https://github.com/apache/ozone/pull/10054.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
