szetszwo commented on code in PR #10000:
URL: https://github.com/apache/ozone/pull/10000#discussion_r3175500259
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/SCMNodeManager.java:
##########
@@ -1103,6 +1103,27 @@ public void
recordPendingAllocationForDatanode(DatanodeID datanodeID, ContainerI
pendingContainerTracker.recordPendingAllocationForDatanode(datanodeInfo,
containerID);
}
+ @Override
+ public boolean checkSpaceAndRecordAllocation(DatanodeID datanodeID,
ContainerID containerID) {
+ DatanodeInfo datanodeInfo = getNode(datanodeID);
+ if (datanodeInfo == null) {
+ LOG.warn("DatanodeInfo not found for node {}", datanodeID);
+ return false;
+ }
+ return pendingContainerTracker.checkSpaceAndRecordAllocation(datanodeInfo,
containerID);
+ }
+
+ @Override
+ public void removePendingAllocationForDatanode(DatanodeID datanodeID,
ContainerID containerID) {
+ DatanodeInfo datanodeInfo = getNode(datanodeID);
Review Comment:
@ashishkumar50 , we should get datanodeInfo outside the loop instead get it
for each element.
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/SCMNodeManager.java:
##########
@@ -1103,6 +1103,27 @@ public void
recordPendingAllocationForDatanode(DatanodeID datanodeID, ContainerI
pendingContainerTracker.recordPendingAllocationForDatanode(datanodeInfo,
containerID);
}
+ @Override
+ public boolean checkSpaceAndRecordAllocation(DatanodeID datanodeID,
ContainerID containerID) {
+ DatanodeInfo datanodeInfo = getNode(datanodeID);
+ if (datanodeInfo == null) {
+ LOG.warn("DatanodeInfo not found for node {}", datanodeID);
+ return false;
+ }
+ return pendingContainerTracker.checkSpaceAndRecordAllocation(datanodeInfo,
containerID);
+ }
+
+ @Override
+ public void removePendingAllocationForDatanode(DatanodeID datanodeID,
ContainerID containerID) {
+ DatanodeInfo datanodeInfo = getNode(datanodeID);
Review Comment:
@ashishkumar50 , we should get datanodeInfo outside the loop instead get it
for each container.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
