sodonnel commented on code in PR #10236:
URL: https://github.com/apache/ozone/pull/10236#discussion_r3225476371
##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/TestOMUpgradeFinalization.java:
##########
@@ -93,12 +99,10 @@ void testOMUpgradeFinalizationWithOneOMDown() throws
Exception {
long prepareIndex = omClient.prepareOzoneManager(120L, 5L);
assertClusterPrepared(prepareIndex, runningOms);
AuditLogTestUtils.verifyAuditLog(OMAction.UPGRADE_PREPARE,
AuditEventStatus.SUCCESS);
-
omClient.cancelOzoneManagerPrepare();
AuditLogTestUtils.verifyAuditLog(OMAction.UPGRADE_CANCEL,
AuditEventStatus.SUCCESS);
- StatusAndMessages response =
- omClient.finalizeUpgrade("finalize-test");
- System.out.println("Finalization Messages : " + response.msgs());
+ // Send the finalize command to SCM which triggers the OM finalize
when SCM reports it is complete.
+ cluster.getStorageContainerLocationClient().finalizeUpgrade();
Review Comment:
I guess this work (now and in preexisting tests) because the audit log check
retries until it finds what it needs.
I didn't know there was a system audit log. I guess its still kind of
triggered by the use, as someone has to send a finalize command which then
propagates through the system.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
