adoroszlai commented on code in PR #10247:
URL: https://github.com/apache/ozone/pull/10247#discussion_r3238517018
##########
hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/protocolPB/ReconfigureProtocolClientSideTranslatorPB.java:
##########
@@ -202,13 +200,4 @@ public List<String> listReconfigureProperties() throws
IOException {
throw ProtobufHelper.getRemoteException(e);
}
}
-
- @Override
- public boolean isMethodSupported(String methodName) throws IOException {
- return RpcClientUtil.isMethodSupported(rpcProxy,
- ReconfigureProtocolPB.class,
- RPC.RpcKind.RPC_PROTOCOL_BUFFER,
- RPC.getProtocolVersion(ReconfigureProtocolPB.class),
- methodName);
Review Comment:
@ivandika3 @xichen01 `ReconfigureProtocolClientSideTranslatorPB` is marked
as stable, but private, and was copied from Hadoop in Ozone 1.4. Do you think
it's OK to remove this method? This is the only use for most of the code being
removed in this PR. No other Ozone protocol implements `ProtocolMetaInterface`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
