ivandika3 commented on code in PR #10247:
URL: https://github.com/apache/ozone/pull/10247#discussion_r3245293547
##########
hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/protocolPB/ReconfigureProtocolClientSideTranslatorPB.java:
##########
@@ -202,13 +200,4 @@ public List<String> listReconfigureProperties() throws
IOException {
throw ProtobufHelper.getRemoteException(e);
}
}
-
- @Override
- public boolean isMethodSupported(String methodName) throws IOException {
- return RpcClientUtil.isMethodSupported(rpcProxy,
- ReconfigureProtocolPB.class,
- RPC.RpcKind.RPC_PROTOCOL_BUFFER,
- RPC.getProtocolVersion(ReconfigureProtocolPB.class),
- methodName);
Review Comment:
I think we can assume that `ReconfgureProtocolClientSideTranslatorPB` is not
going to be used externally since the `InterfaceAudience` is private. Similarly
to other classes like `ClientProtocol`, we can assume that it's private by
default (should not be extended externally by other external clients since we
don't enforce any compatibility). So I'm OK with this removal.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
