chihsuan commented on code in PR #10352:
URL: https://github.com/apache/ozone/pull/10352#discussion_r3293882406
##########
hadoop-ozone/dist/src/shell/ozone/ozone:
##########
@@ -177,7 +177,7 @@ function ozonecmd_case
;;
httpfs)
OZONE_SUBCMD_SUPPORTDAEMONIZATION="true"
- OZONE_OPTS="${OZONE_OPTS} ${RATIS_OPTS} -Dhttpfs.home.dir=${OZONE_HOME}
-Dhttpfs.config.dir=${OZONE_CONF_DIR} -Dhttpfs.log.dir=${OZONE_HOME}/log
-Dhttpfs.temp.dir=${OZONE_HOME}/temp
-Dlog4j.configuration=file:${OZONE_CONF_DIR}/log4j.properties
${OZONE_MODULE_ACCESS_ARGS}"
+ OZONE_HTTPFS_OPTS="${OZONE_HTTPFS_OPTS} ${RATIS_OPTS}
-Dhttpfs.home.dir=${OZONE_HOME} -Dhttpfs.config.dir=${OZONE_CONF_DIR}
-Dhttpfs.log.dir=${OZONE_HOME}/log -Dhttpfs.temp.dir=${OZONE_HOME}/temp
-Dlog4j.configuration=file:${OZONE_CONF_DIR}/log4j.properties
${OZONE_MODULE_ACCESS_ARGS}"
Review Comment:
**One subtle point:** this follows the existing `OZONE_S3G_OPTS` /
`OZONE_RECON_OPTS` pattern by appending the built-in defaults after the
user-provided component opts. That means user-provided duplicate` -Dhttpfs.*`
properties in `OZONE_HTTPFS_OPTS` will not override the built-in HttpFS
properties, because Java uses the last duplicate -D value.
I think this is acceptable for consistency with the other daemons, which is
the explicit goal of HDDS-14443. `OZONE_HTTPFS_OPTS` is meant for adding JVM
options; letting users override the built-in `httpfs.*` paths would be a
broader, cross-daemon change and is out of scope here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
