jojochuang commented on PR #10352:
URL: https://github.com/apache/ozone/pull/10352#issuecomment-4530565595

     ### 1.  OZONE_GC_SETTINGS
   
     As indicated by the comments in the  ozone-env.sh  template, this variable 
is not used by default in any script logic:
   
       # NOTE: this is not used by default!
       # You can define variables right here and then re-use them later on.
       # For example, it is common to use the same garbage collection settings
       # for all the daemons. So one could define:
       #
       # export OZONE_GC_SETTINGS="-verbose:gc -XX:+PrintGCDetails 
-XX:+PrintGCTimeStamps -XX:+PrintGCDateStamps"
       #
       # .. and then use it when setting OZONE_OM_OPTS, etc. below
   
     • Status: It is completely unused by the Ozone framework itself.
     • Purpose: It exists purely as a helper template variable for 
administrators who want to define general Garbage Collection settings in one 
place and
     manually reference them inside other options (e.g.,  export 
OZONE_OM_OPTS="${OZONE_OM_OPTS} ${OZONE_GC_SETTINGS}" ).
     ──────
     ### 2.  OZONE_SECURE_IDENT_PRESERVE
   
     This variable is defined in the  ozone-env.sh  template but is never 
referenced or checked anywhere in the active shell scripts ( ozone ,  ozone-
     config.sh ,  ozone-functions.sh ):
   
       # When running a secure daemon, the default value of OZONE_IDENT_STRING
       # ends up being a bit bogus.  Therefore, by default, the code will
       # replace OZONE_IDENT_STRING with OZONE_xx_SECURE_USER.  If one wants
       # to keep OZONE_IDENT_STRING untouched, then uncomment this line.
       # export OZONE_SECURE_IDENT_PRESERVE="true"
   
     • Status: It is a dead configuration remnant and is completely ignored.
     • Origin: This was inherited from the Apache Hadoop shell scripts (where  
HADOOP_SECURE_IDENT_PRESERVE  is used to prevent the script from overriding
     HADOOP_IDENT_STRING  with the secure daemon user name). During the 
fork/adaptation of the shell scripts into Ozone, the actual logic that reads 
this
     variable was omitted or removed from the  
ozone_generic_java_subcmd_handler  function in  ozone-functions.sh .


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to