navinko commented on code in PR #10405:
URL: https://github.com/apache/ozone/pull/10405#discussion_r3344489759
##########
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/protocol/DatanodeID.java:
##########
@@ -45,7 +45,7 @@ private DatanodeID(final UUID uuid) {
}
// Mainly used for JSON conversion
- public String getID() {
+ public String getUuid() {
Review Comment:
Thanks @szetszwo for the suggestions.
Addressed the review comments and used getUuidStringForTesting for tests
only and updated HddsTestUtils.
Since earlier the balancer's robot test, jq was referring
"datanodeDetails.id.uuid" and getUuid() was available in DatanodeID class so
the test succeeded but with rename to getUuidStringForTesting caused uuid
being null . I used datanodeDetails.uuidString instead of
datanodeDetails.id.uuidStringForTesting to make robot test succeed.
CI Build :
https://github.com/navinko/ozone/actions/runs/26844028091/job/79160804056
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
