amaliujia commented on code in PR #10439:
URL: https://github.com/apache/ozone/pull/10439#discussion_r3366352027
##########
hadoop-hdds/client/src/test/java/org/apache/hadoop/hdds/scm/storage/TestBufferPool.java:
##########
@@ -94,14 +85,12 @@ private void
assertAllocationBlockedUntilReleased(BufferPool pool, Deque<ChunkBu
releaser.start();
allocator.join();
assertEquals(toRelease, allocated.get());
- assertTrue(logCapturer.getOutput().contains("Allocation needs to wait the
pool is at capacity"));
Review Comment:
Good point. Yes `assertFull(pool)` does state checks.
I am wondering if other people can also take a look at this before we merge.
cc @adoroszlai.
This is just in case if there was hidden context for such log based testing
that we do not know. And certainly if bugs exist in such code path (e.g. a
while loop + wait in BufferPool), it is relatively hard to debug.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
