ivandika3 commented on PR #10876: URL: https://github.com/apache/ozone/pull/10876#issuecomment-5102405726
> The first key in iterator is k00 and delete keys is k01. If pointer at deleted key is greater than iterator then iterator seeks to deleted key by adding the current deleteRange to the deleteRangeList. So the iterator is at k01 now. Let's say that between k00 and k01, there are 1 millions tombstones, the RocksDB iterator is forced to iterate all these 100,000 entries. This will make performance unpredictable. The deleteRange on [k01, k03) is not going to be worth it in that case. There is a RocksDB multiget https://github.com/facebook/rocksdb/wiki/MultiGet-Performance to improve performance of multiget, we can probably explore this, but I don't think the proposed algorithm above is the way to go. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
