ptlrs commented on PR #10876:
URL: https://github.com/apache/ozone/pull/10876#issuecomment-5111887377
Thanks for the PR @ivandika3. Removing this configuration should be ok. As
per the RocksDB source, `exclusive_manual_compaction=true` is not required
since 2021/prior to 7.7.3.
```c
// When a manual compaction arrives, temporarily disable scheduling of
// non-manual compactions and wait until the number of scheduled compaction
// jobs drops to zero. This used to be needed to ensure that this manual
// compaction can compact any range of keys/files. Now it is optional
// (see `CompactRangeOptions::exclusive_manual_compaction`). The use case
for
// `exclusive_manual_compaction=true` is unclear beyond not trusting the
code.
```
-
https://github.com/facebook/rocksdb/blob/01cd296b079d1c82e28bfddd6850d7de876aaf6d/db/db_impl/db_impl_compaction_flush.cc#L1858-L1864
- https://github.com/facebook/rocksdb/pull/10317
This scenario has essentially stalled writes by creating a backpressure in
the write flow. While removing this configuration helps, the scenario may still
reproduce if L0 to L1 compaction slows down due to any other reason. We may
need to revisit the values for max_subcompactions, max_background_compactions
and max_background_jobs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
