errose28 commented on code in PR #10777:
URL: https://github.com/apache/ozone/pull/10777#discussion_r3678518071
##########
hadoop-ozone/interface-client/src/main/proto/OmClientProtocol.proto:
##########
@@ -554,12 +554,13 @@ enum Status {
DIRECTORY_NOT_EMPTY = 68;
- PERSIST_UPGRADE_TO_LAYOUT_VERSION_FAILED = 69;
- REMOVE_UPGRADE_TO_LAYOUT_VERSION_FAILED = 70;
- UPDATE_LAYOUT_VERSION_FAILED = 71;
- LAYOUT_FEATURE_FINALIZATION_FAILED = 72;
- PREPARE_FAILED = 73; // Deprecated
- NOT_SUPPORTED_OPERATION_WHEN_PREPARED = 74; // Deprecated
+ PERSIST_UPGRADE_TO_LAYOUT_VERSION_FAILED = 69; // [deprecated = true]
+ REMOVE_UPGRADE_TO_LAYOUT_VERSION_FAILED = 70; // [deprecated = true]
+ UPDATE_LAYOUT_VERSION_FAILED = 71; // [deprecated = true]
+ LAYOUT_FEATURE_FINALIZATION_FAILED = 72; // [deprecated = true]
+ PREPARE_FAILED = 73; // [deprecated = true]
+ NOT_SUPPORTED_OPERATION_WHEN_PREPARED = 74; // [deprecated = true]
Review Comment:
Enum entries can't actually be deprecated in protobuf, so it is to
communicate the intent. We could optionally switch this to just `// deprecated`
if using official protobuf syntax where it is not technically supported is
confusing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
