errose28 commented on code in PR #10777: URL: https://github.com/apache/ozone/pull/10777#discussion_r3678575793
########## hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/protocolPB/TestOMAdminProtocolServerSideImpl.java: ########## @@ -0,0 +1,45 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hadoop.ozone.protocolPB; + +import static org.junit.jupiter.api.Assertions.assertEquals; +import static org.mockito.Mockito.mock; + +import com.google.protobuf.ServiceException; +import org.apache.hadoop.ozone.OzoneManagerVersion; +import org.apache.hadoop.ozone.om.OzoneManager; +import org.apache.hadoop.ozone.protocol.proto.OzoneManagerAdminProtocolProtos.GetPeerUpgradeStatusRequest; +import org.apache.hadoop.ozone.protocol.proto.OzoneManagerAdminProtocolProtos.GetPeerUpgradeStatusResponse; +import org.junit.jupiter.api.Test; + +/** + * Tests for {@link OMAdminProtocolServerSideImpl#getPeerUpgradeStatus}. + */ +public class TestOMAdminProtocolServerSideImpl { + + @Test + public void testGetPeerUpgradeStatusReturnsSoftwareVersion() throws ServiceException { + OzoneManager om = mock(OzoneManager.class); + + OMAdminProtocolServerSideImpl handler = new OMAdminProtocolServerSideImpl(om); + GetPeerUpgradeStatusResponse response = + handler.getPeerUpgradeStatus(null, GetPeerUpgradeStatusRequest.newBuilder().build()); + + assertEquals(OzoneManagerVersion.SOFTWARE_VERSION.serialize(), response.getOmSoftwareVersion()); Review Comment: I don't think this suggestion makes sense. We are testing the server side method. It happens to not use the OM mock, but I don't see an issue if the implementation changed and the server side code started using the OM instance for this method. ########## hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/protocolPB/TestOMAdminProtocolServerSideImpl.java: ########## @@ -0,0 +1,45 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hadoop.ozone.protocolPB; + +import static org.junit.jupiter.api.Assertions.assertEquals; +import static org.mockito.Mockito.mock; + +import com.google.protobuf.ServiceException; +import org.apache.hadoop.ozone.OzoneManagerVersion; +import org.apache.hadoop.ozone.om.OzoneManager; +import org.apache.hadoop.ozone.protocol.proto.OzoneManagerAdminProtocolProtos.GetPeerUpgradeStatusRequest; +import org.apache.hadoop.ozone.protocol.proto.OzoneManagerAdminProtocolProtos.GetPeerUpgradeStatusResponse; +import org.junit.jupiter.api.Test; + +/** + * Tests for {@link OMAdminProtocolServerSideImpl#getPeerUpgradeStatus}. + */ +public class TestOMAdminProtocolServerSideImpl { + + @Test + public void testGetPeerUpgradeStatusReturnsSoftwareVersion() throws ServiceException { + OzoneManager om = mock(OzoneManager.class); + + OMAdminProtocolServerSideImpl handler = new OMAdminProtocolServerSideImpl(om); + GetPeerUpgradeStatusResponse response = + handler.getPeerUpgradeStatus(null, GetPeerUpgradeStatusRequest.newBuilder().build()); + + assertEquals(OzoneManagerVersion.SOFTWARE_VERSION.serialize(), response.getOmSoftwareVersion()); Review Comment: I don't think this suggestion makes sense. We are testing the server side method. It happens to not use the OM mock, but I don't see an issue if the implementation changed and the server side code started using the OM instance in this method. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
