errose28 commented on code in PR #10777:
URL: https://github.com/apache/ozone/pull/10777#discussion_r3678700907
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java:
##########
@@ -3650,8 +3650,7 @@ public StatusAndMessages finalizeUpgrade(String
unusedUpgradeClientId)
return FINALIZED_MSG;
}
versionManager.finalizeUpgrade();
- // OM clients currently require STARTING_MSG to be returned when this
method succeeds.
- // TODO This will be removed when OM learns to finalize from SCM.
Review Comment:
There's still some things left over from the old finalize command here. The
API used by old clients should be left for compatibility and return the
corresponding enum while triggering the finalization start from OM. New clients
will get the current response. Filed HDDS-16025.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
