F64116045 commented on PR #10928:
URL: https://github.com/apache/ozone/pull/10928#issuecomment-5343511724

   Following the discussion in 
[apache/ozone#10983](https://github.com/apache/ozone/pull/10983#discussion_r3793455906),
 I also moved the data-space check from `SCMCommonPlacementPolicy` into 
`PendingContainerTracker`.
   
   Previously, [`SCMCommonPlacementPolicy` did this check 
directly](https://github.com/apache/ozone/blob/fedac595fbda6c31cf2be0727d7651b6f96c74df/hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/SCMCommonPlacementPolicy.java#L334-L355).
   
   Now [`SCMCommonPlacementPolicy` delegates to 
`NodeManager.hasAvailableSpace(...)`](https://github.com/apache/ozone/blob/1b674003d443ea026a7ae85f48685827d92905d0/hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/SCMCommonPlacementPolicy.java#L323-L329),
 and the combined check lives in 
[`PendingContainerTracker`](https://github.com/apache/ozone/blob/1b674003d443ea026a7ae85f48685827d92905d0/hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/PendingContainerTracker.java#L303-L335).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to