F64116045 commented on code in PR #10928:
URL: https://github.com/apache/ozone/pull/10928#discussion_r3831972688
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/pipeline/PipelineManagerImpl.java:
##########
@@ -728,6 +730,14 @@ public boolean checkSpaceAndRecordAllocation(Pipeline
pipeline, ContainerID cont
return true;
}
+ private StorageType getStorageTypeForPendingAllocation(Pipeline pipeline) {
+ StorageTier storageTier = pipeline.getSupportedStorageTier();
+ if (storageTier == null || storageTier == StorageTier.EMPTY) {
+ return null;
+ }
+ return storageTier.getUniformStorageType();
Review Comment:
Thanks for raising this.
The existing pipeline selection path also maps the tier through
`storageTier.getUniformStorageType()` in
[RatisPipelineProvider](https://github.com/apache/ozone/blob/fedac595fbda6c31cf2be0727d7651b6f96c74df/hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/pipeline/RatisPipelineProvider.java#L182-L184)
and
[PipelineProvider](https://github.com/apache/ozone/blob/fedac595fbda6c31cf2be0727d7651b6f96c74df/hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/pipeline/PipelineProvider.java#L91-L97)
and there is no fallback, so I think it is acceptable here?
(If fallback should be handled differently, I’m happy to update it, thanks.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
