F64116045 commented on code in PR #10928:
URL: https://github.com/apache/ozone/pull/10928#discussion_r3813881527
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/SCMNodeManager.java:
##########
@@ -1078,22 +1078,36 @@ public DatanodeInfo getDatanodeInfo(DatanodeDetails dn)
{
*/
@Override
public boolean hasSpaceForNewContainerAllocation(DatanodeID datanodeID) {
+ return hasSpaceForNewContainerAllocation(datanodeID, null);
+ }
+
+ @Override
+ public boolean hasSpaceForNewContainerAllocation(
+ DatanodeID datanodeID, StorageType storageType) {
DatanodeInfo datanodeInfo = getNode(datanodeID);
if (datanodeInfo == null) {
LOG.warn("DatanodeInfo not found for node {}", datanodeID);
return false;
}
- return
pendingContainerTracker.hasEffectiveAllocatableSpaceForNewContainer(datanodeInfo);
+ return pendingContainerTracker.hasEffectiveAllocatableSpaceForNewContainer(
+ datanodeInfo, storageType);
}
@Override
public void recordPendingAllocationForDatanode(DatanodeID datanodeID,
ContainerID containerID) {
Review Comment:
Removed the untyped `recordPendingAllocationForDatanode(...)`; callers now
pass `StorageType`. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
