F64116045 commented on code in PR #10928:
URL: https://github.com/apache/ozone/pull/10928#discussion_r3885715388
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/SCMCommonPlacementPolicy.java:
##########
@@ -323,37 +320,15 @@ public static boolean hasEnoughSpace(DatanodeDetails
datanodeDetails,
DatanodeInfo datanodeInfo = (DatanodeInfo) datanodeDetails;
- // Data-space check: use PendingContainerTracker slot availability.
- // This accounts for both current disk usage and in-flight allocations.
+ // Data-space check: use PendingContainerTracker availability.
+ // This accounts for current disk usage, storage type and in-flight
allocations.
// Always slot-based (maxContainerSize unit).
- if (!nodeManager.hasAvailableSpace(datanodeInfo)) {
+ if (!nodeManager.hasAvailableSpace(
+ datanodeInfo, dataSizeRequired, storageType)) {
Review Comment:
Removed `dataSizeRequired` from the `hasAvailableSpace` call. also cleaned
up the matching `hasEnoughSpace` overload so it does not carry that unused
parameter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
