F64116045 commented on PR #10928: URL: https://github.com/apache/ozone/pull/10928#issuecomment-5460691623
Thanks all for the reviews. Main changes since previous revision: - Removed `dataSizeRequired` from the `hasAvailableSpace` data-space check. - Changed pending allocation tracking to bucket by storage type. - Renamed `getStorageTypeForPendingAllocation` to `getStorageType`. One extra cleanup after syncing with the latest base branch: removed the old [`ContainerReplicaPendingOps.scheduleAddReplica(...)` overload](https://github.com/apache/ozone/pull/10928/commits/245d501653b830618826a7dfdf522f24da220539#diff-f3034ae3ea8d7f634ad8bb7b052c9e29832dd2660f710f2d1fc38d7b48a1e651L168-L179) that did not take `StorageType`, existing tests now pass `null` explicitly where storage type is not part of the test. Please let me know if the mechanical cleanup makes the diff too large to review. I can split that part out or reduce the scope. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
