sodonnel opened a new pull request, #11230:
URL: https://github.com/apache/ozone/pull/11230

   ## What changes were proposed in this pull request?
   
   In a recent change ReplicationManagerReport gained an extra field to track 
the end health state of a container when it is processed. While this resulted 
in a smaller code change, this not how RMReport is supposed to be used and it 
was intended to have aggregated stats, not per request stats. We already have 
the ContainerCheckRequest object which has all details of a request and any 
result can be set in there.
   
   This change removes the transient per container state from RMReport and 
moves the result into ContainerCheckRequest where it is better suited. It also 
centralizes the report "increment and sample" so the state and increment are 
performed together with a single call from the handlers.
   
   Also added a new test in TestContainerCheckRequest to ensure that when 
calling request.setHealthState() it updates the report and sets the heath 
result, which avoids having to update all the sets that assert on the report 
state, as that would have made this change a lot larger.
   
   This change is needed before #11199 can move forward as it starts to build 
on the pattern added to the report.
   
   ## What is the link to the Apache JIRA
   
   https://issues.apache.org/jira/browse/HDDS-16405
   
   ## How was this patch tested?
   
   Existing tests and a new unit test.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to