sodonnel commented on code in PR #11230:
URL: https://github.com/apache/ozone/pull/11230#discussion_r4034223441
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/replication/ReplicationManager.java:
##########
@@ -878,10 +876,8 @@ protected boolean processContainer(ContainerInfo
containerInfo,
if (!handled) {
LOG.debug("Container {} had no actions after passing through the " +
"check chain", containerInfo.containerID());
- // Container remains HEALTHY (set at start of loop)
}
- // Apply final health state from report to container
- containerInfo.setHealthState(report.getContainerHealthState());
+ containerInfo.setHealthState(checkRequest.getHealthState());
Review Comment:
@devmadhuu I originally did guard this with !readonly, but as copilot
highlighted above (and I confirmed) that caused tests you added to fail.
Thinking about your earlier change which added this logic, will it do any harm
beyond those tests if we add the `!readonly` guard?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
