devmadhuu commented on code in PR #11230:
URL: https://github.com/apache/ozone/pull/11230#discussion_r4046470897
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/replication/ReplicationManager.java:
##########
@@ -878,10 +876,8 @@ protected boolean processContainer(ContainerInfo
containerInfo,
if (!handled) {
LOG.debug("Container {} had no actions after passing through the " +
"check chain", containerInfo.containerID());
- // Container remains HEALTHY (set at start of loop)
}
- // Apply final health state from report to container
- containerInfo.setHealthState(report.getContainerHealthState());
+ containerInfo.setHealthState(checkRequest.getHealthState());
Review Comment:
Thanks @sodonnel for highlighting this. I think you are right to point out,
this check of `if (!readOnly)` will break ReconReplicationManager scan, as it
runs with readonly true. So rest all looks good to me..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
