chihsuan commented on code in PR #11271:
URL: https://github.com/apache/ozone/pull/11271#discussion_r4063068002
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/NodeDecommissionManager.java:
##########
@@ -281,8 +281,11 @@ public NodeDecommissionManager(OzoneConfiguration config,
NodeManager nm, Contai
ScmConfigKeys.OZONE_SCM_DATANODE_ADMIN_MONITOR_INTERVAL_DEFAULT,
TimeUnit.MILLISECONDS);
-
setMaintenanceConfigs(config.getInt("hdds.scm.replication.maintenance.replica.minimum",
2),
- config.getInt("hdds.scm.replication.maintenance.remaining.redundancy",
1));
+ // Read the maintenance replica config from
ReplicationManagerConfiguration,
+ // which is the single source of truth for these values.
Review Comment:
nit: Could we drop this comment? The code already says where the values come
from.
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
