navinko commented on PR #11271: URL: https://github.com/apache/ozone/pull/11271#issuecomment-5763056705
> Thanks for the cleanup! @navinko LGTM +1 > > Just curious, since both keys are reconfigurable and only ReplicationManager picks up a reconfig today, could `checkIfMaintenancePossible` read `rmConf` directly instead of copying the values? Happy to see that as a follow-up too. Left a small nit inline. Thanks @chihsuan for the review. Yes, it's doable . I'll do the rmConf read as the follow-up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
