chihsuan commented on code in PR #12101:
URL: https://github.com/apache/ozone/pull/12101#discussion_r4651586957


##########
.github/workflows/check.yml:
##########
@@ -247,6 +247,23 @@ jobs:
           path: ~/.cache/ozone
           key: hadoop-${{ env.HADOOP_VERSION }}
 
+      - name: Restore Hadoop AWS dependencies
+        id: restore-hadoop-deps
+        # TODO reduce hard-code in HDDS-17509
+        if: ${{ inputs.script == 'acceptance' && contains(inputs.split, 
'test-s3a.sh') }}
+        uses: apache/infrastructure-actions/stash/restore@restore/v1
+        with:
+          path: ~/.cache/ozone/maven-repo
+          key: hadoop-${{ env.HADOOP_VERSION }}-deps
+
+      - name: Set custom local repo
+        # TODO reduce hard-code in HDDS-17509
+        if: ${{ inputs.script == 'acceptance' && contains(inputs.split, 
'test-s3a.sh') && steps.restore-hadoop-deps.outputs.stash-hit == 'true' }}
+        run: |
+          # use custom local repo for Hadoop AWS dependencies, included in 
stash
+          MAVEN_ARGS="$MAVEN_ARGS 
-Dmaven.repo.local=${HOME}/.cache/ozone/maven-repo"
+          echo "MAVEN_ARGS=$MAVEN_ARGS" >> "$GITHUB_ENV"

Review Comment:
   `GITHUB_ENV` makes the custom repo apply to the whole job, including 
`get_version` in `acceptance.sh`. That may re-download its Maven extensions and 
plugins on each run, since they aren't in the stash. Could we limit it to the 
`hadoop-aws` mvn calls?
   
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to