adoroszlai commented on code in PR #12101:
URL: https://github.com/apache/ozone/pull/12101#discussion_r4653252446


##########
.github/actions/setup-java-with-cache/action.yml:
##########
@@ -58,8 +58,13 @@ runs:
     - name: Calculate cache key
       id: cache-key
       shell: bash
-      run: |
-        echo "value=maven-repo-${{ hashFiles('**/pom.xml', 
'.mvn/extensions.xml', '.mvn/wrapper/maven-wrapper.properties') }}" >> 
"$GITHUB_OUTPUT"
+      run: >
+        echo "value=maven-repo-${{ hashFiles(
+            '**/pom.xml',
+            '.mvn/extensions.xml',
+            '.mvn/wrapper/maven-wrapper.properties',
+            'dev-support/ci/populate-cache.sh'

Review Comment:
   I think it depends on:
   - `$TEST_JAVA_VERSION`
   - the command to fetch plugin dependencies
   - the command to get Java 21-specific dependencies
   
   We could:
   - add $TEST_JAVA_VERSION to the cache key
   - move the plugin dependencies command into `populate-cache.sh` (and 
3rd-party stashes after the Ozone cache)
   
   I'll try if we can remove the Java 21 part.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to