chihsuan commented on code in PR #12101:
URL: https://github.com/apache/ozone/pull/12101#discussion_r4652817972


##########
.github/actions/setup-java-with-cache/action.yml:
##########
@@ -58,8 +58,13 @@ runs:
     - name: Calculate cache key
       id: cache-key
       shell: bash
-      run: |
-        echo "value=maven-repo-${{ hashFiles('**/pom.xml', 
'.mvn/extensions.xml', '.mvn/wrapper/maven-wrapper.properties') }}" >> 
"$GITHUB_OUTPUT"
+      run: >
+        echo "value=maven-repo-${{ hashFiles(
+            '**/pom.xml',
+            '.mvn/extensions.xml',
+            '.mvn/wrapper/maven-wrapper.properties',
+            'dev-support/ci/populate-cache.sh'

Review Comment:
   
   Thanks for adding this! Should we also include `populate-cache.yml`?



##########
hadoop-ozone/dev-support/checks/_lib.sh:
##########
@@ -103,8 +103,8 @@ get_version() {
   local tempfile=$(mktemp)
   local -i rc=0
 
-  # output version/transfer etc. to stderr first
-  ./mvnw --batch-mode --non-recursive --show-version \
+  # redirect output to stderr
+  ./mvnw --batch-mode --non-recursive --offline --show-version \

Review Comment:
   Good call on `--offline`. Could we retry online if offline resolution fails? 
local or older CI caches may lack required dependencies.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to