fapifta commented on a change in pull request #2910:
URL: https://github.com/apache/ozone/pull/2910#discussion_r768266617
##########
File path:
hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/io/ECKeyOutputStream.java
##########
@@ -303,13 +327,40 @@ private StripeWriteStatus handleParityWrites(int
parityCellSize,
if (allocateBlockIfFull) {
blockOutputStreamEntryPool.allocateBlockIfNeeded();
}
+ currentBlockGroupLen = 0;
} else {
streamEntry.resetToFirstEntry();
}
- currentBlockGroupLen = 0;
+
return StripeWriteStatus.SUCCESS;
}
+ private boolean isDataWriteSuccess() {
Review comment:
This two method, along with the unchanged addToExcludedNodesList method
seems to belong to ECBlockOutputStreamEntryPool, as all the method logic
operates on that class, or the current stream entry which is contained by the
pool instance. I think these should be moved over to
ECBlockOutputStreamEntryPool.
Also all of the places where these methods are called, the result is negated
in the check, so we can invert the return values, and call these methods as
hasWriteFailure and hasPutBlockFailure.
##########
File path:
hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/io/ECKeyOutputStream.java
##########
@@ -502,6 +551,27 @@ public void close() throws IOException {
ecChunkBufferCache.release();
}
+ private void handleStripeFailure(int lastStripeSize, int parityCellSize,
Review comment:
I would use config.getEcWriteMaxRetries() if we rename the property and
the related methods to this name, and remove the instance variable used here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
